fix(helm): allow helm v4 binary in airgap (#3174)#3188
Open
Mallikarjunadevops wants to merge 1 commit intodevspace-sh:mainfrom
Open
fix(helm): allow helm v4 binary in airgap (#3174)#3188Mallikarjunadevops wants to merge 1 commit intodevspace-sh:mainfrom
Mallikarjunadevops wants to merge 1 commit intodevspace-sh:mainfrom
Conversation
Mallikarjunadevops
requested review from
FabianKramm and
LukasGentele
as code owners
✅ Deploy Preview for devspace-docs canceled.Built without sensitive environment variables
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3174.
This Pull Request introduces an isolated
helm/downloadermodule to successfully intercept theIsValidcheck for the Helm module. By securely bypassing the.v3:regex lock, DevSpace now seamlessly resolves locally-installed Helm binaries matchingv3.orv4.without inadvertently triggering a missing network download fromget.helm.shunder airgapped restrictions.Tested successfully via Go tests and
go build ./...locally.